-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prompt version hash #27
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -83,6 +83,9 @@ export class PromptVariants { | |||
slug: { | |||
equals: slug, | |||
}, | |||
variant: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the one-liner - it was updating all variants to not be current after creating each one. I missed this in testing.
@@ -11,7 +11,6 @@ A well-thought-out lesson plan should: | |||
* Include some engaging activities to help reinforce the learning points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bumps the prompt so that we all get a new hash and don't need to clear our local database table
Quality Gate passedIssues Measures |
@@ -22,6 +22,7 @@ | |||
"format": "prettier --write \"**/*.{ts,tsx,md}\"", | |||
"lint": "turbo lint", | |||
"prompts": "turbo prompts --filter=core", | |||
"prompts:dev": "turbo prompts:dev --filter=core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you run this it should fill up your prompts table with all prompts and variants
const created = await prompts.setCurrent(variantSlug, true); | ||
promptId = created?.id; | ||
} catch (e) { | ||
console.error("Error creating prompt", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This throws below with instructions to run pnpm prompts:dev
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description