feat: add an incrementing iteration number to the chat #263
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
| @@ -320,7 +334,7 @@ describe("Aila", () => { | |||
| expect(ailaInstance.lesson.plan.title).toBe("Mocked Lesson Plan"); | |||
| expect(ailaInstance.lesson.plan.subject).toBe("Mocked Subject"); | |||
| expect(ailaInstance.lesson.plan.keyStage).toBe("key-stage-3"); | |||
| }); | |||
| }, 8000); | |||
There was a problem hiding this comment.
Do we still need these extended timeouts if we're using the mock categoriser?
| @@ -94,6 +99,7 @@ export class AilaStreamHandler { | |||
| await this.fetchChunkFromStream(); | |||
| } catch (error) { | |||
| await this._chat.generationFailed(error); | |||
| throw error; | |||
| public setPlan(plan: LooseLessonPlan) { | ||
| this._plan = plan; | ||
| } |
There was a problem hiding this comment.
I think that we could do with some better patterns for getters and setters. For just the plan, we have the class definition, setting the initial value in the initialiser, 2 setter methods and a getter
I assume we don't need the two setters, but it's indicative of the problem of not having a nice pattern
Something like parameter properties, but I think that would only work for non-destructured properties
|
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description