Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Typescript to 5.3.3 #24

Merged
merged 4 commits into from
Aug 29, 2024
Merged

chore: update Typescript to 5.3.3 #24

merged 4 commits into from
Aug 29, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Aug 29, 2024 •
edited
Loading

Description

  • Updates Typescript to 5.3.3 (two minor versions behind)
  • Updates Typescript eslint to 7.18 (one major version behind)
  • @typescript-eslint/typescript-estree does not support Typescript >= 5.4 so we are blocked on upgrading to latest Typescript until this package supports it

Checklist

  • Does this PR update a package with a breaking change

@vercel Vercel
Copy link

vercel bot commented Aug 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:24am

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@stefl stefl requested a review from a team August 29, 2024 08:18
@stefl stefl changed the title feat: update Typescript to 5.5.4 chore: update Typescript to 5.5.4 Aug 29, 2024
@codeincontext codeincontext self-requested a review August 29, 2024 08:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefl
Copy link
Contributor Author

stefl commented Aug 29, 2024

It looks like we can't bump to Typescript 5.5 because @typescript-eslint/typescript-estree does not yet support >= 5.4. So this brings us up to 5.3.2 and 7.18 for typescript-eslint (one major version behind).

@stefl stefl changed the title chore: update Typescript to 5.5.4 chore: update Typescript to 5.3.3 Aug 29, 2024
codeincontext
codeincontext approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up description

@stefl stefl merged commit ac54789 into main Aug 29, 2024
15 checks passed
@stefl stefl deleted the feat/typescript_554 branch August 29, 2024 09:43
@simonrose121 simonrose121 mentioned this pull request Sep 2, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen pushed a commit that referenced this pull request Oct 3, 2024
@stefl
chore: update Typescript to 5.3.3 (#24)
b9c0845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext