Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update prompt with distractor, practice task and grammar improvements #23

Merged
merged 5 commits into from
Aug 29, 2024
Merged

feat: update prompt with distractor, practice task and grammar improvements #23

merged 5 commits into from
Aug 29, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Aug 28, 2024 •
edited
Loading

Description

  • Update the prompt to:
    • improve distractor length so that it is more consistent with answer length
    • improve slide text for learning cycles
    • improve practice task relevance, content and duration
    • address grammar issues in the text
    • standardise on double quotes
    • standardise one sentence per line for easier diffs

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 7:18am

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefl stefl changed the title feat: update prompt with pre-launch changes feat: update prompt with distractor, practice task and grammar improvements Aug 29, 2024
codeincontext
codeincontext approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stefl stefl merged commit cb65f9c into main Aug 29, 2024
14 checks passed
@stefl stefl deleted the feat/prelaunch_prompt branch August 29, 2024 09:49
@simonrose121 simonrose121 mentioned this pull request Sep 2, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen pushed a commit that referenced this pull request Oct 3, 2024
@stefl
feat: update prompt with distractor, practice task and grammar improv…
9cf3004 
…ements (#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext