Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence unknown part type errors #229

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: silence unknown part type errors #229

merged 1 commit into from
Oct 15, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 15, 2024

Description

  • We have a very chatty error on Sentry due to the "unknown" part type. 15k requests per 30 days. This silences these errors since the "unknown" occurs during streaming and part validation before a type is detected.

Issue(s)

Fixes Sentry 3220470

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 10:21am

@stefl stefl requested a review from a team October 15, 2024 10:19
Copy link

Copy link

github-actions bot commented Oct 15, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@stefl stefl merged commit 2e3e56b into main Oct 15, 2024
13 of 14 checks passed
@stefl stefl deleted the fix/unknown_part_type branch October 15, 2024 11:11
@codeincontext codeincontext mentioned this pull request Oct 15, 2024
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants