fix: reduce middleware syntax error logs, send to logs, tests for CSP in each env #213
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stefl
changed the title
| @@ -149,7 +152,7 @@ export async function authMiddleware( | |||
| return response; | |||
| } | |||
| } catch (error) { | |||
| console.error("Error in authMiddleware", error); | |||
| console.error({ event: "middleware.auth.error", error }); | |||
There was a problem hiding this comment.
If we log JSON then Datadog is able to query it
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
…tested. Add tests
| return NextResponse.json({ error: "Internal Server Error" }, { status: 500 }); | ||
| } | ||
|
|
||
| const cspConfig: CspConfig = { |
There was a problem hiding this comment.
Moving this to a config allows us to test the CSP generation without relying on ENV being set.
| const sentryEnv = process.env.NEXT_PUBLIC_SENTRY_ENV; | ||
| const sentryRelease = process.env.NEXT_PUBLIC_APP_VERSION; | ||
| const sentryReportUri = `${process.env.SENTRY_REPORT_URI}&sentry_environment=${sentryEnv}&sentry_release=${sentryRelease}`; | ||
| function generateNonce(): string { |
There was a problem hiding this comment.
I'm not too happy about this. Because it's an edge function, and we're running the test in node we need a way to generate the nonce in both environments.
stefl
changed the title
There was a problem hiding this comment.
These are snapshots so that we can review if there are any changes to how the CSP is generated
| @@ -0,0 +1,14 @@ | |||
| default-src 'self' | |||
| media-src 'self' 'self' https://*.mux.com https://stream.mux.com blob: | |||
There was a problem hiding this comment.
@codeincontext is this a bug? Should there be as string after blob:?
There was a problem hiding this comment.
Not a bug, just a bit of an oddity to represent a scheme
| const savedPolicies = readPoliciesFromFile(env); | ||
| expect(generatedPolicies).toBe(savedPolicies); | ||
| } | ||
| expect(generatedPolicies).toMatchSnapshot(); |
|
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description