feat: add users to Hubspot on creation #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
| undefined, | ||
| undefined, | ||
| undefined, | ||
| undefined, |
There was a problem hiding this comment.
I feel like they could change the signature here!
There was a problem hiding this comment.
Yeah, I'm actually a little unimpressed by that package in general. For example, it doesn't export their error instances
| ); | ||
| id = result.id; | ||
| } catch (e) { | ||
| if (e instanceof ApiException && e.code === 404) { |
There was a problem hiding this comment.
What's the 404 saying here?
If it means no user found then we wouldn't want to return early, right?
There was a problem hiding this comment.
Guessing it doesn't mean that if the code is successfully creating new hubspot entities
There was a problem hiding this comment.
Oh, you're right. Well spotted as I thought I had tested that
… feat/hubspot-backend-creation
|
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
feat: add users to Hubspot on creation
Description
We need to send users to hubspot to be able to send them communications and track their email preferences
Once this work is deployed I will make sure that existing users are up to date in Hubspot. I already have a script to export preferences to a CSV. If that's not useful for the team, I can adapt it to use this client
How to test
Test with the checkbox both enabled and disabled
Test with an email that already exists in hubspot, and a new account
Checklist