Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hook error on sign-in page #208

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: hook error on sign-in page #208

merged 1 commit into from
Nov 21, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 8, 2024

Description

  • This attempts to fix an issue where the sign in page was rendering with a different number of hooks
  • If the user is logged in and visits /sign-in it redirects to /

Issue(s)

Fixes Sentry issue 3875705

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 5:06pm

Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@stefl stefl requested a review from a team October 8, 2024 17:11
@codeincontext
Copy link
Collaborator

We updated the version of Clerk on October 10th, but it doesn't look like it's fixed the issue. It's frustrating as the change here implies that it's a bug in Clerk's package

Have you been able to replicate this locally, or is this fix a "try it and see" situation? I'd recommend adding a comment to explain why it's here and when it can be removed

@stefl
Copy link
Contributor Author

stefl commented Nov 21, 2024

We updated the version of Clerk on October 10th, but it doesn't look like it's fixed the issue. It's frustrating as the change here implies that it's a bug in Clerk's package

Have you been able to replicate this locally, or is this fix a "try it and see" situation? I'd recommend adding a comment to explain why it's here and when it can be removed

This is a fix and see if it works for sure. If we want to try it and see if it removes the Sentry error then we could try it, otherwise happy to close.

@codeincontext
Copy link
Collaborator

Ok, why don't we merge and if the error continues we can decide whether to revert it 👍

@codeincontext codeincontext merged commit c298b10 into main Nov 21, 2024
14 checks passed
@codeincontext codeincontext deleted the fix/sign-in-rerender branch November 21, 2024 15:22
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.16.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants