-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hook error on sign-in page #208
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Quality Gate passedIssues Measures |
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
We updated the version of Clerk on October 10th, but it doesn't look like it's fixed the issue. It's frustrating as the change here implies that it's a bug in Clerk's package Have you been able to replicate this locally, or is this fix a "try it and see" situation? I'd recommend adding a comment to explain why it's here and when it can be removed |
This is a fix and see if it works for sure. If we want to try it and see if it removes the Sentry error then we could try it, otherwise happy to close. |
Ok, why don't we merge and if the error continues we can decide whether to revert it 👍 |
🎉 This PR is included in version 1.16.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Issue(s)
Fixes Sentry issue 3875705