Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): chat and message level feedback #20

Merged
merged 24 commits into from
Sep 3, 2024
Merged

Conversation

mantagen
Copy link
Collaborator

@mantagen mantagen commented Aug 28, 2024

Description

A combination of

  • @tomwisecodes 's work adding feedback functionality to on lesson plan sections
  • my message id fixes

Issue(s)

How to test

  1. Go to https://oak-ai-lesson-assistant-73pc5tqpt.vercel-preview.thenational.academy
  2. Click on ______
  3. You should see ______

Screenshots

How it used to look (delete if n/a):
{screenshots}

How it should now look:
{screenshots}

Checklist

  • Manually tested across browsers / devices
  • Considered impact on accessibility
  • Does this PR update a package with a breaking change

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:35am

Copy link

github-actions bot commented Aug 28, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

}: {
role: "user" | "assistant" | "system";
}) {
return `${role[0]}-${nanoid(16)}`;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I distinguished between roles in development ... do we want to keep?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

apps/nextjs/src/app/layout.tsx Outdated Show resolved Hide resolved
id,
path: `/aila/${id}`,
id: chatId,
path: `/aila/${chatId}`,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be storing path against the record, but will remove that another time

packages/api/src/router/appSessions.ts Show resolved Hide resolved
packages/db/prisma/schema.prisma Show resolved Hide resolved
@mantagen mantagen requested a review from a team August 28, 2024 16:29
@mantagen mantagen marked this pull request as ready for review August 28, 2024 16:29
{ label: "Shorten content", enumValue: "SHORTEN_CONTENT" },
{ label: "Add more detail", enumValue: "ADD_MORE_DETAIL" },
{ label: "Other", enumValue: "OTHER" },
] as const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

sonarqubecloud bot commented Sep 3, 2024

@mantagen mantagen merged commit bd4462a into main Sep 3, 2024
12 checks passed
@mantagen mantagen deleted the feat/in-app-feedback branch September 3, 2024 12:37
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants