Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates to download resources page #17

Merged
merged 13 commits into from
Aug 29, 2024
Merged

Conversation

mantagen
Copy link
Collaborator

@mantagen mantagen commented Aug 28, 2024

Description

  • Changes to 'download' page as specified in Miro
  • Change progress to show 10 sections rather than 12 (reducing the first three into lessonDetails)
  • Copy updates
  • Important: changes functionality of progress checker to reflect the reality that 1 learning cycle is a valid state (so 'Learning cycles' gets a tick in this case)
  • Changes a bunch of copy to use Sentence case

Issue(s)

Fixes https://www.notion.so/oaknationalacademy/Update-descriptions-of-each-section-on-the-download-resources-page-164770c7a7fa419c94a8367cf64f3d8f?pvs=4

How to test

  1. Go to https://oak-ai-lesson-assistant-a59flyrtc.vercel-preview.thenational.academy
  2. Go to a chat -> downloads
  3. You should see new progress sections as in the image below
  4. You should see the 10 sections change reflected in the progress bar on the chat too

Screenshots

How it used to look (delete if n/a):

Uploading image.png…

How it should now look:

image

@mantagen mantagen requested a review from a team August 28, 2024 11:42
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 3:29pm

Copy link
Contributor

@stefl stefl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - glad we're now using the same completeness code in both places

Copy link

github-actions bot commented Aug 28, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

sections,
totalSections,
totalSectionsComplete,
} = useDownloadView(chat);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is mostly changing the file name. But the introduction of this hook is the substantive change in this file

{`${totalSectionsComplete} of ${totalSections} sections complete`}
</span>
</div>
{sections.map((section) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also using this sections array rather than what was in the previous version

@mantagen mantagen requested a review from a team August 29, 2024 14:10
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mantagen mantagen merged commit 4f55547 into main Aug 29, 2024
11 of 12 checks passed
@mantagen mantagen deleted the fix/download-sections branch August 29, 2024 15:33
@mikeritson-oak
Copy link
Collaborator

General changes and functionality of this fix are looking good. One thing I noted was that there was a request in Miro for a couple of icon changes but these don't seem to have been reflected in this PR:
image

@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants