-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updates to download resources page #17
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - glad we're now using the same completeness code in both places
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
sections, | ||
totalSections, | ||
totalSectionsComplete, | ||
} = useDownloadView(chat); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is mostly changing the file name. But the introduction of this hook is the substantive change in this file
{`${totalSectionsComplete} of ${totalSections} sections complete`} | ||
</span> | ||
</div> | ||
{sections.map((section) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also using this sections array rather than what was in the previous version
Quality Gate failedFailed conditions |
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
lessonDetails
)Issue(s)
Fixes https://www.notion.so/oaknationalacademy/Update-descriptions-of-each-section-on-the-download-resources-page-164770c7a7fa419c94a8367cf64f3d8f?pvs=4
How to test
Screenshots
How it used to look (delete if n/a):
How it should now look: