fix: quiz designer snags #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
stefl
reviewed
Sep 11, 2024
| const { top } = questionsWrapper.getBoundingClientRect(); | ||
| window.scrollTo({ | ||
| top: top + window.pageYOffset - 200, | ||
| behavior: "smooth", |
There was a problem hiding this comment.
I think we can add <html class="scroll-smooth"> so we don't need to re-specify smooth scrolling everywhere
stefl
approved these changes
Sep 11, 2024
codeincontext
pushed a commit
that referenced
this pull request
Sep 12, 2024
codeincontext
pushed a commit
that referenced
this pull request
Sep 12, 2024
simonrose121
pushed a commit
that referenced
this pull request
Sep 16, 2024
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
mantagen
pushed a commit
that referenced
this pull request
Oct 3, 2024
mantagen
pushed a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issus in:
https://www.notion.so/oaknationalacademy/Quiz-Designer-Issues-e94d079850f349709023b751fe31bae2