Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor linting #384

Merged
merged 31 commits into from
Nov 26, 2024
Merged

fix: minor linting #384

merged 31 commits into from
Nov 26, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Nov 26, 2024 •
edited
Loading

Description

  • This addresses some of the items marked as Minor in our Sonar Cloud report
  • The idea is to reduce down some of the very small issues so that we can more easily triage the intermediate and major items that have been flagged

Things included:

  • Typos
  • Options chains
  • Nullish coalescing
  • Readonly attributes on classes
  • Combining type imports
  • Empty fragments
  • Unnecessary return

stefl added 25 commits November 26, 2024 11:32
@stefl
fix: typo in lesson sections
5c6c6c1
@stefl
fix: use option chain
aa3d48e
@stefl
fix: use option chain and scrollY
5f2fcf8
@stefl
fix: use scrollY
d47d8d3
@stefl
fix: remove empty fragment
a592928
@stefl
fix: option chain and scrollY
75ba7de
@stefl
fix: option chain
a1d0a41
@stefl
fix: nullish coalescing
0c5d240
@stefl
fix: remove unused import
7347b03
@stefl
Add proptypes to img mock
1c17303
@stefl
Add cspell ignore
ee24e6a
@stefl
Remove unused import
7066afc
@stefl
Use option chain for match
9d0f494
@stefl
Remove unused return
80c3585
@stefl
Set attributes as readonly on Aila
4d72aa5
@stefl
Combine type imports in AilaChat
6df4385
@stefl
Set attributes to readonly in AilaStreamHandler
91a844c
@stefl
Set attributes as readonly in AilaLesson
6cdd2be
@stefl
Set responseObject to readonly in MockLLMService
ddf1a4e
@stefl
Simplify boolean logic in OpenAIService
c86f7ab
@stefl
Simplify boolean logic in AilaLessonPromptBuilder
a600259
@stefl
Set attributes as readonly in AilaAnalytics
e600fd0
@stefl
Set Attributes as readonly in DataDogAnalyticsAdapter
e6dce0c
@stefl
Set attributes as readonly in PosthogAnalytics Adapter
baf0001
@stefl
Do not allow string in SpeakerNotesTag type
772fd12
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant 🛑 Canceled (Inspect) Nov 26, 2024 1:37pm

@stefl stefl changed the title Fix/minor linting fix: minor linting Nov 26, 2024
@stefl stefl requested a review from a team November 26, 2024 12:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Playwright test results

passed  14 passed
flaky  1 flaky
skipped  1 skipped

Details

report  Open report ↗︎
stats  16 tests across 15 suites
duration  2 minutes, 44 seconds
commit  d056058

Flaky tests

No persona › tests/modifiy-lesson.test.ts › Modify a lesson plan › Modify a lesson resource

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

codeincontext
codeincontext approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though I'm not sure we care too much about the MSW file

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefl stefl merged commit ec4ce6e into main Nov 26, 2024
16 checks passed
@stefl stefl deleted the fix/minor_linting branch November 26, 2024 13:44
@mikeritson-oak mikeritson-oak mentioned this pull request Nov 26, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefl @oak-machine-user @codeincontext