refactor: move error outside of loop

oaknational · Nov 22, 2024 · b17a846 · b17a846
1 parent cf48fdf
commit b17a846
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/apps/nextjs/src/app/api/cron-jobs/expired-exports/route.ts b/apps/nextjs/src/app/api/cron-jobs/expired-exports/route.ts
@@ -54,14 +54,13 @@ async function updateExpiredAtAndDelete(fileIds: string[]) {
       log.error(`Error processing file with gdriveFileId: ${id}`, error);
       failedIds.push(id);
     }
-
-    if (failedIds.length > 0) {
-      const errorMessage = `Failed to process the following file IDs: ${failedIds.join(
-        ", ",
-      )}`;
-      log.error(errorMessage);
-      throw new Error(errorMessage);
-    }
+  }
+  if (failedIds.length > 0) {
+    const errorMessage = `Failed to process the following file IDs: ${failedIds.join(
+      ", ",
+    )}`;
+    log.error(errorMessage);
+    throw new Error(errorMessage);
   }
 }