Merge branch 'main' into fix/intent_prom

oaknational · Nov 28, 2024 · 892bb7b · 892bb7b
2 parents baeec8f + 1ed9d60
commit 892bb7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/apps/nextjs/src/components/AppComponents/Chat/chat-lessonPlanDisplay.tsx b/apps/nextjs/src/components/AppComponents/Chat/chat-lessonPlanDisplay.tsx
@@ -12,9 +12,8 @@ import Skeleton from "../common/Skeleton";
 import DropDownSection from "./drop-down-section";
 import { GuidanceRequired } from "./guidance-required";
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function notEmpty(value: any) {
-  return ![null, undefined, ""].includes(value);
+export function notEmpty(value: unknown) {
+  return value !== null && value !== undefined && value !== "";
 }
 
 function basedOnTitle(basedOn: string | BasedOnOptional) {
@@ -56,7 +55,7 @@ export const LessonPlanDisplay = ({
     useState(false);
 
   useEffect(() => {
-    const handleUserScroll = () => {
+    const handleUserScroll = (event: WheelEvent) => {
       // Check for mousewheel or touch pad scroll event
       event?.type === "wheel" && setUserHasCancelledAutoScroll(true);
     };

diff --git a/packages/aila/src/features/moderation/moderators/index.ts b/packages/aila/src/features/moderation/moderators/index.ts
@@ -1,8 +1,8 @@
 import type { ModerationResult } from "@oakai/core/src/utils/ailaModeration/moderationSchema";
 
 export abstract class AilaModerator {
-  private _userId: string | undefined;
-  private _chatId: string | undefined;
+  protected _userId: string | undefined;
+  protected _chatId: string | undefined;
 
   constructor({ userId, chatId }: { userId?: string; chatId?: string }) {
     this._userId = userId;