chore: qa bits

oaknational · Nov 13, 2024 · 284e505 · 284e505
1 parent 478ddff
commit 284e505
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/apps/nextjs/src/components/DialogControl/ContentOptions/ModalFooterButtons.tsx b/apps/nextjs/src/components/DialogControl/ContentOptions/ModalFooterButtons.tsx
@@ -1,4 +1,6 @@
-import { OakFlex, OakLink, OakSpan } from "@oaknational/oak-components";
+import { OakFlex, OakSpan } from "@oaknational/oak-components";
+
+import { OakLinkNoUnderline } from "@/components/OakLinkNoUnderline";
 
 const ModalFooterButtons = ({
   closeDialog,
@@ -17,11 +19,11 @@ const ModalFooterButtons = ({
       $pb="inner-padding-m"
     >
       {actionButtonStates()}
-      <OakLink onClick={() => closeDialog()}>
+      <OakLinkNoUnderline onClick={() => closeDialog()} element="button">
         <OakSpan $font="body-2-bold" $color="black" $textDecoration="none">
           Cancel
         </OakSpan>
-      </OakLink>
+      </OakLinkNoUnderline>
     </OakFlex>
   );
 };

diff --git a/apps/nextjs/src/components/DialogControl/ContentOptions/ShareChatDialog.tsx b/apps/nextjs/src/components/DialogControl/ContentOptions/ShareChatDialog.tsx
@@ -68,8 +68,9 @@ const ShareChat = ({
           element={Link}
           href={`/aila/${chatId}/share`}
           target="_blank"
+          iconName="external"
         >
-          Go to share page
+          View share page
         </OakPrimaryButton>
       );
     }

diff --git a/apps/nextjs/src/components/DialogControl/DialogContents.tsx b/apps/nextjs/src/components/DialogControl/DialogContents.tsx
@@ -19,7 +19,7 @@ const dialogTitlesAndIcons: Record<
   { title: string; iconName: OakIconName }
 > = {
   "share-chat": {
-    title: "Share chat",
+    title: "Share lesson",
     iconName: "share",
   },
   feedback: {
@@ -67,7 +67,7 @@ const DialogContents = ({
       <OakModalCenterBody
         title={dialogTitlesAndIcons[dialogWindow].title}
         iconName={dialogTitlesAndIcons[dialogWindow].iconName}
-        hideIcon={dialogWindow === "feedback"}
+        hideIcon={dialogWindow === "feedback" || dialogWindow === "share-chat"}
       >
         {children}
         {dialogWindow === "share-chat" && chatId && (

diff --git a/apps/nextjs/src/components/OakLinkNoUnderline.tsx b/apps/nextjs/src/components/OakLinkNoUnderline.tsx
@@ -0,0 +1,6 @@
+import { OakLink } from "@oaknational/oak-components";
+import styled from "styled-components";
+
+export const OakLinkNoUnderline = styled(OakLink)`
+  text-decoration: none;
+`;