-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTC-85: files needed component #3103
Conversation
✅ Deploy Preview for oak-web-application ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for owa-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…aknational/Oak-Web-Application into feat/ctc-85-files-needed-block
Just a couple of minor things from me:
|
src/components/TeacherComponents/LessonOverviewFilesNeeded/LessonOverviewFilesNeeded.tsx
Outdated
Show resolved
Hide resolved
src/components/TeacherComponents/LessonOverviewFilesNeeded/LessonOverviewFilesNeeded.tsx
Outdated
Show resolved
Hide resolved
src/components/TeacherComponents/LessonOverviewFilesNeeded/LessonOverviewFilesNeeded.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments.
Also, can you add story for LessonOverviewFilesNeeded
?
src/components/TeacherComponents/LessonOverviewFilesNeeded/LessonOverviewFilesNeeded.test.tsx
Show resolved
Hide resolved
that's apart of the next download ticket as there was no beta downloads page i've added all the download functionality to that ticket ctc-86 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - tested on beta page in mobile and different browsers with no issues. Downloads url to be tested in the next ticket
🎉 This PR is included in version 1.664.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Music year: 1965
FilesNeeded
component and adds it to the Lesson Details on lesson overviewIssue(s)
Fixes #CTC-85
N.B. Currently no beta downloads page will be addressed on this ticket CTC-86
ACs:
LessonOverviewHelper
, add a new field/variant for ‘Files needed for this lesson’How to test
https://deploy-preview-3103--oak-web-application.netlify.thenational.academy/teachers/beta/lessons/the-origins-of-rock-rock-n-roll
https://deploy-preview-3103--oak-web-application.netlify.thenational.academy/teachers/beta/lessons/fundamentals-of-rock
FilesNeeded
component renders on the Lesson Overview pagesScreenshots
How it should now look:
Checklist