Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTC-85: files needed component #3103

Merged
merged 18 commits into from
Jan 16, 2025
Merged

CTC-85: files needed component #3103

merged 18 commits into from
Jan 16, 2025

Conversation

k-huggs
Copy link
Contributor

@k-huggs k-huggs commented Jan 10, 2025

Description

Music year: 1965

  • Creates FilesNeeded component and adds it to the Lesson Details on lesson overview
  • Adds tertiary button to link to downloads page
  • Updates lesson_content version
  • Updates curriculum schema version

Issue(s)

Fixes #CTC-85

N.B. Currently no beta downloads page will be addressed on this ticket CTC-86

ACs:

  • add ‘Files needed for this lesson’ section to lesson overview page
  • using LessonOverviewHelper , add a new field/variant for ‘Files needed for this lesson’
  • ‘Download lesson file’ button for single file
  • ‘Download lesson files’ button for multiple files
  • ‘Download lesson file’ button links to Downloads page - Currently not available on the beta pages
    • selects only the downloadable file(s) on the Downloads page (same behaviour as the slide deck, worksheets etc buttons on the lesson overview page)
  • lists all files to downloads (name, extension and file size)
  • All files can be downloaded (potentially lesson files could be zipped if there is a large number. ????

How to test

  1. Go to https://deploy-preview-3103--oak-web-application.netlify.thenational.academy/teachers/beta/lessons/structure-in-north-indian-classical-music#lesson-details

https://deploy-preview-3103--oak-web-application.netlify.thenational.academy/teachers/beta/lessons/the-origins-of-rock-rock-n-roll

https://deploy-preview-3103--oak-web-application.netlify.thenational.academy/teachers/beta/lessons/fundamentals-of-rock

  1. FilesNeeded component renders on the Lesson Overview pages

Screenshots

How it should now look:

Screenshot 2025-01-10 at 16 29 21
Screenshot 2025-01-10 at 16 30 48

Checklist

  • Added or updated tests where appropriate
  • Manually tested across browsers / devices
  • Considered impact on accessibility
  • Design sign-off
  • Approved by product owner
  • Does this PR update a package with a breaking change

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for oak-web-application ready!

Name Link
🔨 Latest commit e7269d1
🔍 Latest deploy log https://app.netlify.com/sites/oak-web-application/deploys/6787f55ed8b8c60008610977
😎 Deploy Preview https://deploy-preview-3103--oak-web-application.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for owa-storybook ready!

Name Link
🔨 Latest commit e7269d1
🔍 Latest deploy log https://app.netlify.com/sites/owa-storybook/deploys/6787f55e83fced000a8cd886
😎 Deploy Preview https://deploy-preview-3103--owa-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messmike
Copy link

Just a couple of minor things from me:

  • There is an extra 's' in the copy: 'Downloads these files to use in the lesson' - can we remove so it reads: 'Download these files to use in the lesson.' (with a full stop at the end).
  • Is it possible to capitalise the file type that appears in brackets? E.g. (MP3)

@RBrownsett
Copy link

@k-huggs nothing major (other than what @messmike has mentioned). Just checking the url of the file downloads is just the standard url:
image
Will the ability to populate the url with the pre-selected download come in the next ticket (like we do for worksheets for example)?

Copy link
Contributor

@weronika-szalas weronika-szalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments.
Also, can you add story for LessonOverviewFilesNeeded?

@k-huggs
Copy link
Contributor Author

k-huggs commented Jan 15, 2025

@k-huggs nothing major (other than what @messmike has mentioned). Just checking the url of the file downloads is just the standard url: image Will the ability to populate the url with the pre-selected download come in the next ticket (like we do for worksheets for example)?

that's apart of the next download ticket as there was no beta downloads page i've added all the download functionality to that ticket ctc-86

Copy link

@RBrownsett RBrownsett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - tested on beta page in mobile and different browsers with no issues. Downloads url to be tested in the next ticket

@k-huggs k-huggs merged commit a8d7c6a into main Jan 16, 2025
33 checks passed
@k-huggs k-huggs deleted the feat/ctc-85-files-needed-block branch January 16, 2025 09:14
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.664.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants