Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lesq 1185/unit downloads [LESQ-1185] #3046

Merged
merged 44 commits into from
Jan 15, 2025
Merged

Conversation

njblore
Copy link
Contributor

@njblore njblore commented Dec 2, 2024

Description

This combines LESQ-1185 and LESQ-1196

  • Add a UnitDownloadButton component with states for feature flag variants, signed in status and download status
  • Create helper fns for unit downloads similar to lesson download fns

The experiement for this can be seen here on posthog

How to test

  1. Go to https://deploy-preview-3046--oak-web-application.netlify.thenational.academy/teachers/programmes/geography-primary-ks1/units/local-area-where-do-we-go-to-school/lessons
  2. Which button you see will depend on which cohort of the experiment you have been placed in, you need to add yourself to this feature flag in either group (without adding yourself you will be placed in the control group)
  3. In the control group, or if the unit download does not exist, the button should not show
  4. When signed out: clicking the unit download button should navigate you to the sign in journey, then redirect to this page
    option a:
Screenshot 2024-12-02 at 12 14 15

option b:
Screenshot 2024-12-02 at 14 14 54

  1. When signed in: clicking the button should trigger the download to start, the button will update with a loading spinner and a message will show
Screenshot 2024-12-02 at 12 14 32 Screenshot 2024-12-02 at 12 14 41
  1. An error state should show when there is an error
Screenshot 2024-12-02 at 12 15 59

Copy link

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for oak-web-application ready!

Name Link
🔨 Latest commit 2b55859
🔍 Latest deploy log https://app.netlify.com/sites/oak-web-application/deploys/67879eee2004ea0008a50728
😎 Deploy Preview https://deploy-preview-3046--oak-web-application.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for owa-storybook ready!

Name Link
🔨 Latest commit 2b55859
🔍 Latest deploy log https://app.netlify.com/sites/owa-storybook/deploys/67879eeee59cca0008ed832e
😎 Deploy Preview https://deploy-preview-3046--owa-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jack-skerrett-oak jack-skerrett-oak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we go with what we have for now. There are some fixes that will be done in future tickets, but getting unit downloads so we can test it behind the feature flag in prod is the most important thing for now.

@njblore njblore merged commit a512289 into main Jan 15, 2025
33 checks passed
@njblore njblore deleted the feat/lesq-1185/unit-downloads branch January 15, 2025 11:55
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.660.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants