Skip to content

Commit

Permalink
Remove Prettier from the Stylelint config (#33)
Browse files Browse the repository at this point in the history
Relies on pure Stylelint config based on the Bootstrap's config instead.

1. Removes Prettier dependency.
2. Restores single quote, what is our preference in general.
3. Breaks Prettier's leading zero preference: values like `0.5`
   must be .5 now; since the leading zero is optional,
   it's forced to remove it.
4. Breaks Prettier's no newline preference: multiline properties
   require new line after colon from now.
  • Loading branch information
viktor-yakubiv authored Oct 6, 2020
1 parent 1dde2fa commit cf23453
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/stylelint-config-base/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ module.exports = {
extends: [
'stylelint-config-twbs-bootstrap/css',
'stylelint-config-css-modules',
'stylelint-prettier/recommended',
],
rules: {
'at-rule-no-unknown': [true, { ignoreAtRules: ['extend'] }],
Expand All @@ -14,5 +13,6 @@ module.exports = {
'always',
{ except: ['after-single-line-comment', 'first-nested'] },
],
'string-quotes': 'single',
},
}
6 changes: 2 additions & 4 deletions packages/stylelint-config-base/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@oacore/stylelint-config-base",
"version": "1.0.6",
"description": "Global stylelint configuration across our projects",
"description": "CORE style guide and standard for CSS",
"author": "CORE Team <[email protected]>",
"homepage": "https://github.com/oacore/configs#readme",
"license": "MIT",
Expand All @@ -12,9 +12,7 @@
},
"dependencies": {
"stylelint-config-css-modules": "^2.2.0",
"stylelint-config-prettier": "^8.0.1",
"stylelint-config-twbs-bootstrap": "^2.0.3",
"stylelint-prettier": "^1.1.2"
"stylelint-config-twbs-bootstrap": "^2.0.3"
},
"peerDependencies": {
"stylelint": ">=13.6.0"
Expand Down

0 comments on commit cf23453

Please sign in to comment.