Ci changes #424
Open
Ci changes #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dupondje
commented
Nov 22, 2024
dupondje
commented
- Drop CentOS 8
- Use latest Alma 9
- Upgrade CodeQL to fix deprecation
- Fix builds due to setuptools <> packaging incompatibility
Signed-off-by: Jean-Louis Dupond <[email protected]>
Signed-off-by: Jean-Louis Dupond <[email protected]>
CodeQL v2 is deprecated and almost removed: https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/ So upgrade to the v3 version. Signed-off-by: Jean-Louis Dupond <[email protected]>
The fix in 9897045 did not really fix the issue with setuptools and packaging incompatibility. The issue is that tox creates a new virtualenv with latest setuptools/pip from pypi. But the newest setuptools version is incompatible with the system's packaging version (20.9 on c9s). So first thing we do is installing packaging>=22.0 into the venv to make sure the next installs don't fail. Signed-off-by: Jean-Louis Dupond <[email protected]>
dupondje
requested review from
aesteve-rh,
mz-pdm,
almusil and
tinez
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.