Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/ovirt_disk_attachment: Correct checking if a disk attachment has been destroyed #162

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jul 11, 2019

Signed-off-by: imjoey [email protected]

Fixes #161

Changes proposed in this pull request:

  • Parse the rs.Primary.ID into respective ID of vm and disk-attachment and then check the existence of the specific disk-attachment
  • Change the parameters of function getVMIDAndDiskID() to better fit for general purpose

Output from acceptance testing:

$ make testacc TEST=./ovirt TESTARGS='-run=TestAccOvirtDiskAttachment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ovirt -v -run=TestAccOvirtDiskAttachment_basic -timeout 180m
=== RUN   TestAccOvirtDiskAttachment_basic
--- PASS: TestAccOvirtDiskAttachment_basic (2.66s)
PASS
ok      github.com/ovirt/terraform-provider-ovirt/ovirt 2.695s

Parse the rs.Primary.ID into respective ID of vm and disk-attachment

Signed-off-by: imjoey <[email protected]>
@imjoey imjoey merged commit f8d2bb0 into oVirt:master Jul 11, 2019
@imjoey imjoey deleted the fix_importing_disk_attachment branch July 11, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/ovirt_disk_attachment: testAccCheckDiskAttachmentDestroy function won't work as expected
1 participant