Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune the unnecessary scripts #153

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Jul 3, 2019

It's not the duty of this provider to format terraform configuration files, so this pull request will remove relevant scripts.

Signed-off-by: imjoey [email protected]

Changes proposed in this pull request:

  • Remove unused scripts files related to terraform fmt
  • Remove the .terraform-version which is used by the scripts to be removed

Since it's not the duty of provider to format tf configuration files,
remove tf-fmt related scripts.

Signed-off-by: imjoey <[email protected]>
@imjoey imjoey requested a review from rgolangh July 3, 2019 10:58
@imjoey
Copy link
Member Author

imjoey commented Jul 3, 2019

Hi @rgolangh , Could you please help me review this? Thanks.

@rgolangh
Copy link
Contributor

rgolangh commented Jul 3, 2019

/LGTM

@rgolangh rgolangh merged commit 6f4ad0e into oVirt:master Jul 3, 2019
@imjoey imjoey deleted the prune_scripts branch July 4, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants