Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles: hosted_engine_setup: check if abrt config files exists on HE deploy #397

Merged
merged 1 commit into from
Dec 2, 2021
Merged

roles: hosted_engine_setup: check if abrt config files exists on HE deploy #397

merged 1 commit into from
Dec 2, 2021

Conversation

hbraha
Copy link
Contributor

@hbraha hbraha commented Dec 1, 2021 •
edited by arachmani
Loading

Our abrt configuration is not being used on latest versions since we started
using 'systemd-coredump'.
because of that we should Restore initial abrt config files only when
they exist (on older versions).

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@hbraha
Copy link
Contributor Author

hbraha commented Dec 1, 2021

ci test please

@arachmani
Copy link
Member

@hbraha please add changelog

@mwperina
Copy link
Member

mwperina commented Dec 1, 2021

ci add to whitelist

@hbraha
Copy link
Contributor Author

hbraha commented Dec 1, 2021

ci test please

arachmani
arachmani requested changes Dec 1, 2021
View reviewed changes
roles/hosted_engine_setup/tasks/initial_clean.yml Outdated Show resolved Hide resolved
roles/hosted_engine_setup/tasks/initial_clean.yml Outdated Show resolved Hide resolved
roles/hosted_engine_setup/tasks/initial_clean.yml Outdated Show resolved Hide resolved
roles/hosted_engine_setup/tasks/initial_clean.yml Outdated Show resolved Hide resolved
changelogs/fragments/397-he_engine_abrt_configuration.yaml Outdated Show resolved Hide resolved
@hbraha
add check if abrt config files exists on HE deploy
de2d0a1 
Our abrt configuration is not being used on lastest versions since we started
using 'systemd-coredump'.
beacuse of that we should Restore initial abrt config files only when
they exists (on older versions).
mwperina
mwperina approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hbraha
Copy link
Contributor Author

hbraha commented Dec 2, 2021

verified locally. el9 failure doesn't seem to be related to the changes.

@arachmani arachmani changed the title Delete abrt from HE setup roles: hosted_engine_setup: check if abrt config files exists on HE deploy Dec 2, 2021
@arachmani arachmani merged commit 869b844 into oVirt:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arachmani arachmani arachmani approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hbraha @ovirt-infra @arachmani @mwperina