Pass on constant upvalues

And some rogue chages because of code guidelines

elements/additionalpower.lua

@@ -51,7 +51,7 @@ A default texture will be applied if the widget is a StatusBar and doesn't have
 local _, ns = ...
 local oUF = ns.oUF
 
-local playerClass = select(2, UnitClass('player'))
+local _, playerClass = UnitClass('player')
 
 -- sourced from FrameXML/AlternatePowerBar.lua
 local ADDITIONAL_POWER_BAR_NAME = ADDITIONAL_POWER_BAR_NAME or 'MANA'

elements/power.lua

@@ -82,6 +82,9 @@ The following options are listed by priority. The first check that returns true
 local parent, ns = ...
 local oUF = ns.oUF
 
+-- sourced from FrameXML/UnitPowerBarAlt.lua
+local ALTERNATE_POWER_INDEX = ALTERNATE_POWER_INDEX or 10
+
 local function getDisplayPower(unit)
 	local _, min, _, _, _, _, showOnRaid = UnitAlternatePowerInfo(unit)
 	if(showOnRaid) then

elements/powerprediction.lua

@@ -43,6 +43,10 @@ A default texture will be applied if the widget is a StatusBar and doesn't have
 local _, ns = ...
 local oUF = ns.oUF
 
+-- sourced from FrameXML/AlternatePowerBar.lua
+local ADDITIONAL_POWER_BAR_INDEX = ADDITIONAL_POWER_BAR_INDEX or 0
+local ALT_MANA_BAR_PAIR_DISPLAY_INFO = ALT_MANA_BAR_PAIR_DISPLAY_INFO
+
 local playerClass = select(2, UnitClass('player'))
 
 local function Update(self, event, unit)

elements/range.lua

@@ -77,7 +77,7 @@ local function Enable(self)
 		table.insert(_FRAMES, self)
 
 		if(not OnRangeFrame) then
-			OnRangeFrame = CreateFrame'Frame'
+			OnRangeFrame = CreateFrame('Frame')
 			OnRangeFrame:SetScript('OnUpdate', OnRangeUpdate)
 		end
 

elements/runes.lua

@@ -36,7 +36,7 @@ A default texture will be applied if the sub-widgets are StatusBars and doesn't
     self.Runes = Runes
 --]]
 
-if select(2, UnitClass('player')) ~= 'DEATHKNIGHT' then return end
+if(select(2, UnitClass('player')) ~= 'DEATHKNIGHT') then return end
 
 local parent, ns = ...
 local oUF = ns.oUF

elements/stagger.lua

@@ -30,11 +30,14 @@ A default texture will be applied if the widget is a StatusBar and doesn't have
     self.Stagger = Stagger
 --]]
 
-if select(2, UnitClass('player')) ~= 'MONK' then return end
+if(select(2, UnitClass('player')) ~= 'MONK') then return end
 
 local parent, ns = ...
 local oUF = ns.oUF
 
+-- sourced from FrameXML/Constants.lua
+local SPEC_MONK_BREWMASTER = SPEC_MONK_BREWMASTER or 1
+
 -- sourced from FrameXML/MonkStaggerBar.lua
 local BREWMASTER_POWER_BAR_NAME = BREWMASTER_POWER_BAR_NAME or 'STAGGER'
 

elements/totems.lua

@@ -23,7 +23,7 @@ OnEnter and OnLeave will be set to display a Tooltip if the `Totem` widget is mo
 ## Examples
 
     local Totems = {}
-    for index = 1, MAX_TOTEMS do
+    for index = 1, 5 do
         -- Position and size of the totem indicator
         local Totem = CreateFrame('Button', nil, self)
         Totem:SetSize(40, 40)