Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language name mismatch #142

Merged
merged 5 commits into from
Nov 5, 2019
Merged

Fix language name mismatch #142

merged 5 commits into from
Nov 5, 2019

Conversation

ZapAnton
Copy link
Contributor

Closes #125.

New help message for the -a flag:

    -a, --ascii_language <ascii_language>    Overrides showing the dominant language ascii logo. Possible values:
                                             [assembly, c, clojure, coffeescript, cpp, csharp, css, dart, elixir, elm,
                                             erlang, forth, fsharp, go, haskell, html, idris, java, javascript, julia,
                                             kotlin, lisp, lua, nim, objectivec, perl, php, prolog, purescript, python,
                                             r, racket, ruby, rust, scala, shell, swift, tcl, tex, typescript, vue, xml,
                                             zig] [default: ]

spenserblack
spenserblack requested changes Nov 1, 2019
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Left a few notes.

src/main.rs Outdated Show resolved Hide resolved
src/language.rs Outdated Show resolved Hide resolved
@ZapAnton
Copy link
Contributor Author

ZapAnton commented Nov 4, 2019

@spenserblack , I have resolved the issues you pointed out, could you give it another look?

spenserblack
spenserblack requested changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍
1 issue though... see my comments below.

src/main.rs Outdated Show resolved Hide resolved
spenserblack
spenserblack approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@spenserblack spenserblack merged commit ce4756e into o2sh:master Nov 5, 2019
@ZapAnton ZapAnton deleted the fix_language_name_mismatch branch November 5, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language name support mismatch
2 participants
@ZapAnton @spenserblack