Add rank:ndcg and rank:map as valid objectives #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the XGBoost docs [1] `rank:ndcg` and `rank:map` are valid objectives, but are currently rejected by the parser. This commits resolves this by extending the list of objectives which map to the no-op normalizer, allowing the models to be parsed and used by the plugin. [1] https://github.com/dmlc/xgboost/blob/1094d6015df7be6f5829e53a4c257f3481b43ee5/doc/parameter.rst#parameters-for-learning-to-rank-rank-ndcg-rank-map-rank-pairwise
|
LGTM, merging with main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use
rank:ndcgas an objective model deployment failed unexpectedly, stating that the objective was invalid.As per the XGBoost docs
rank:ndcgandrank:mapare valid objectives, but are currently rejected by the parser.This change resolves this by extending the list of objectives which map to the no-op normalizer, allowing the models to be parsed and used by the plugin.