-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #237 - Upgrade to elasticsearch 7.3.1 #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment on build.gradle, everything else looks very good.
Thanks!
7.3.1 is out by now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@softwaredoug I could merge as is but since it requires uploading a new build I think that it makes sense that you merge it once you have time to prepare a new release.
It would help us if we could upgrade this to 7.3.1. I think this should not introduce additional api changes. |
upgrade to 7.3.1
Thanks @iagodvsantos @nomoa @jillesvangurp All looks good, but when rebuilding locally I got the following, which I'm hopeful is innocuous:
|
I've been running with the 7.3.1 build today and did not notice this issue. But there may be some issue with the test classpath dependencies for log4j. It may be pulling in different versions for log4j-core and log4j-api transitively. I've seen similar issues on other plugin projects. I think the api dependency might be coming along with elasticsearch. In any case, the solution is adding matching versions of both as test dependencies. |
I can take a look at this tomorrow if needed; but it would be great if you can update the PR directly. |
I was not able to reproduce the log related exception. It produces no output during gradle test. But if this comes back; try adding these dependencies.
|
Note: Since there is an error on
build-tools
es plugin in the version 7.3.1 as stated here -> elastic/elasticsearch#45891 (comment) a workaround was necessaryCloses:. #237