zk lightnet logs command implementation. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimkiv
requested review from
nicc,
ymekuria,
MartinMinkov,
garwalsh,
mitschabaude and
Trivo25
Co-authored-by: Yoni Mekuria <[email protected]>
Co-authored-by: Yoni Mekuria <[email protected]>
Co-authored-by: Yoni Mekuria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zk lightnet logs savecommand does not provide any selection options, because usually it is good idea to grab all relevant logs at certain point in time.zk lightnet logs followcommand, on the contrary, gives users an option to follow the logs of certain processes, well, because you can't simply follow several files without introducing additional complexity (logs from different sources pre-processing) and a bit of mess when you will also need to distinguish which entries are from what processes.Closes #502
As per the RFC.