Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up deploy and log full errors to the console #408

Merged
merged 3 commits into from
May 11, 2023
Merged

Clean up deploy and log full errors to the console #408

merged 3 commits into from
May 11, 2023

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented May 10, 2023 •
edited
Loading

fixes #406

  • no longer use the zkAppKey argument of deploy, which was just a workaround for a missing precondition
    • a snarkyjs PR will remove this argument from snarkyjs, but we can stop using it independently
  • remove other manual patching of zkapp.deploy() that is no longer necessary
  • log full error trace to the console, so debugging CLI failures becomes less painful:

image

@mitschabaude
Copy link
Contributor Author

with the fix in the second commit, it works:
image

ymekuria
ymekuria approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mitschabaude. LGTM! Could you bump the cli version?

@ymekuria ymekuria merged commit a405ac2 into main May 11, 2023
ymekuria added a commit that referenced this pull request May 11, 2023
@mitschabaude @ymekuria
Clean up deploy and log full errors to the console (#408)
eee3715 
Co-authored-by: ymekuria <[email protected]>
@ymekuria ymekuria deleted the fix/sudoku-deploy branch October 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymekuria ymekuria ymekuria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying example Sudoku contract fails
2 participants
@mitschabaude @ymekuria