Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors after zk file #325

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Fix build errors after zk file #325

merged 3 commits into from
Dec 1, 2022

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Nov 30, 2022

this PR makes two changes which are a frequent source of errors when building fresh projects, and in particular, currently break at least two of the tutorials

  • remove the isolatedModules flag from the TS config. this flag frequently causes errors about not being able to compile files without import/exports (e.g., as created by the zk file command). I don't see benefits of having this flag on which would make up for that
  • change the zk file command, to not add an import in the test file like import Contract from './Contract'
    • since the Contract.ts file is initially empty, the test file is initially wrong and can't be built
    • also, it assumes that the smart contract is exported as default, while all our examples export it as a named export
    • so I commented the line out in the test, and changed it to assume a named export

I'm also bumping the version number to get this fix to the community quickly

@mitschabaude mitschabaude changed the title Fix build errors in tutorials Fix build errors after zk file Nov 30, 2022
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants