Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import a smart contract into the Nuxt UI project scaffold #305

Merged
merged 27 commits into from
Nov 29, 2022
Merged

Import a smart contract into the Nuxt UI project scaffold #305

merged 27 commits into from
Nov 29, 2022

Conversation

ymekuria
Copy link
Collaborator

@ymekuria ymekuria commented Nov 14, 2022 •
edited
Loading

Addresses
#295

This PR adds the the template Add smart contract into the index.vue of the UI when Nuxt is selected as the UI framework in the CLI.

@MartinMinkov
Copy link
Contributor

MartinMinkov commented Nov 16, 2022 •
edited
Loading

I seem to get the following error when using create-nuxt-app with Windows:

npx create-nuxt-app@latest t9 create-nuxt-app v5.0.0 ✨ Generating Nuxt.js project in t9 ? Project name: t9 ? Programming language: JavaScript ? Package manager: Yarn ? UI framework: None ? Template engine: HTML ? Nuxt.js modules: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? Linting tools: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? Testing framework: None ? Rendering mode: Universal (SSR / SSG) ? Deployment target: Server (Node.js hosting) ? Development tools: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? What is your GitHub username? martin minkov ? Version control system: Git Trace: TypeError: Cannot convert undefined or null to object at Object.apply (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\cna-template\template\nuxt\package.js:36:18) at Object.loadPackage (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\package.js:21:42) at Object.load (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\package.js:24:26) at Object.handler (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\saofile.js:147:34) at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\sao\lib\runActions.js:103:39 at Array.map (<anonymous>) at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\sao\lib\runActions.js:97:30 at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\majo\dist\majo.cjs.js:58:49 at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\cli.js:56:19

The error seems to be thrown from the CLI. Just wanted to notify that this feature doesn't work on Windows due to the CLI tool itself not working for Windows

@ymekuria
Copy link
Collaborator Author

ymekuria commented Nov 16, 2022 •
edited
Loading

I seem to get the following error when using create-nuxt-app with Windows:

npx create-nuxt-app@latest t9 create-nuxt-app v5.0.0 ✨ Generating Nuxt.js project in t9 ? Project name: t9 ? Programming language: JavaScript ? Package manager: Yarn ? UI framework: None ? Template engine: HTML ? Nuxt.js modules: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? Linting tools: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? Testing framework: None ? Rendering mode: Universal (SSR / SSG) ? Deployment target: Server (Node.js hosting) ? Development tools: (Press <space> to select, <a> to toggle all, <i> to invert selection) ? What is your GitHub username? martin minkov ? Version control system: Git Trace: TypeError: Cannot convert undefined or null to object at Object.apply (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\cna-template\template\nuxt\package.js:36:18) at Object.loadPackage (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\package.js:21:42) at Object.load (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\package.js:24:26) at Object.handler (C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\saofile.js:147:34) at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\sao\lib\runActions.js:103:39 at Array.map (<anonymous>) at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\sao\lib\runActions.js:97:30 at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\majo\dist\majo.cjs.js:58:49 at C:\Users\Martin\AppData\Local\npm-cache\_npx\4e867334d6c50eaa\node_modules\create-nuxt-app\lib\cli.js:56:19

The error seems to be thrown from the CLI. Just wanted to notify that this feature doesn't work on Windows due to the CLI tool itself not working for Windows

@MartinMinkov Did you get the same error when using npm as the package manager?

@MartinMinkov
Copy link
Contributor

@MartinMinkov Did you get the same error when using npm as the package manager?

Yep, something with NPM.

mitschabaude and others added 13 commits November 16, 2022 13:55
@mitschabaude @ymekuria
bump es target for better syntax, sourcemap true
a9b6782
@MartinMinkov @ymekuria
Provide a better error message when an unknown error occurs in deploy…
ea7f9aa 
…ment
@MartinMinkov @ymekuria
Log entire error inside getErrorMessage
71c2aed 
Use the util.format built-in to format the error receieved inside
getErrorMessage(). This gives us better logging and discoverability when
an unknown error occurs. By using util.format, we get the message and
stack properties in the log output.
@MartinMinkov @ymekuria
Bump package.json version to 0.4.20
de2ef63
@mitschabaude @ymekuria
fix error graphql handling
69dd011
@mitschabaude @ymekuria
fixup
7aa26e5
@jasongitmail @ymekuria
Bump version of zkapp-cli to 0.5.0 and snarkyjs to 0.7.0
08ed119
@jasongitmail @ymekuria
update package-lock.json to include 0.7.0 now that it is on npm
0993323
@MartinMinkov @ymekuria
Remove .wait() calls from .send() invocations
0283062
@MartinMinkov @ymekuria
Update Add.ts and Add.test.ts to use new SnarkyJS version
c6d6ced 
Various updates made to support the templates for the new SnarkyJS
version.
- Removed .wait()
- Refactored tests to easily support proving
- Added requireSignature in the Add contract
@jasongitmail @ymekuria
Bump SnarkyJS to 0.7.1 and CLI to 0.5.1
f55da71
@ymekuria
refactor: add config items to top of nuxtconfig
946f8fb
@ymekuria
refactor: add trailing comma to nuxt-vite config option
c3c8508
MartinMinkov
MartinMinkov reviewed Nov 28, 2022
View reviewed changes
src/lib/project.js Outdated Show resolved Hide resolved
MartinMinkov
MartinMinkov approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@MartinMinkov MartinMinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, approving in advance!

@ymekuria ymekuria merged commit 17ed299 into main Nov 29, 2022
@rjdellecese rjdellecese mentioned this pull request Nov 29, 2022
Merged
@ymekuria ymekuria deleted the feature/add-contract-to-nuxt branch November 30, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymekuria @MartinMinkov @mitschabaude @jasongitmail