Add COOP & COEP headers for SvelteKit, NextJS, & NuxtJS #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
approved these changes
Oct 20, 2022
|
@ymekuria Martin added code for Nuxt and updated the Next code. Would you mind try it out again please? |
ymekuria
approved these changes
Oct 21, 2022
| stdio: 'inherit', | ||
| shell: true, | ||
| }); | ||
| sh.rm('-rf', path.join('ui', '.git')); // Remove NextJS' .git; we will init .git in our monorepo's root. |
There was a problem hiding this comment.
Are we init .git in the mono repo yet?
| @@ -286,6 +273,78 @@ function kebabCase(str) { | |||
| return str.toLowerCase().replace(' ', '-'); | |||
| } | |||
|
|
|||
| function scaffoldSvelte() { | |||
There was a problem hiding this comment.
Abstracting the scaffolding into the functions is a clean approach.
|
I was able to generate ui projects that had the correct headers with all the supported frameworks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first commit covers Svelte Kit and NextJS. NuxtJS is still todo.
Closes #267