Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain examples names to valid names #263

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

jasongitmail
Copy link
Contributor

Example error output if user uses an invalid example name:

❯ zk example foo
zk example [name]

Create an example project

Options:
--name [string] [required] [choices: "sudoku", "tictactoe"]
-h, --help Show help [boolean]
-v, --version Show version number [boolean]

Invalid values:
name was "foo". Must be one of: "sudoku", "tictactoe".

(We don't have a lot of flexibility in the formatting of that error message because it must accept three string replacements. But I made it more readable than the default error message provided by yargs.)

Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@jasongitmail jasongitmail merged commit c6f5b20 into main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants