Feature/perf #1878
Open
Feature/perf #1878
+2,917
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 2 commits
October 21, 2024 12:48
A bunch of patches to record some of the node perf data at runtime. disable some reports, mkdir before writing create the dirs so we can write there adding error correction fixing the collecting of output to after the unit tests finish lets try to capture the results fixing the job update dirs now listing the files and running different profs adding more test adding error checking to the copy looking for isolate removing extra move fixing the directories adding in a matrix of profile tests adding node version to matrix rename the artifact to include the node version moving count to 32 perf splitting the keccak test file into parts by the sizes because so larger fixme: refactor to reduce duplicate code and use parameters reduce matrix size perf recording A bunch of patches to record some of the node perf data at runtime. disable some reports, mkdir before writing create the dirs so we can write there adding error correction fixing the collecting of output to after the unit tests finish lets try to capture the results fixing the job update dirs now listing the files and running different profs adding more test adding error checking to the copy looking for isolate removing extra move fixing the directories adding in a matrix of profile tests adding node version to matrix rename the artifact to include the node version moving count to 32 perf splitting the keccak test file into parts by the sizes because so larger fixme: refactor to reduce duplicate code and use parameters reduce matrix size all branchs Refactoring output directory We want the output directories to contain the branch name so we can merge results easily. also using shellcheck https://github.com/mschuett/yaml-shellcheck.git on the yaml. fixing variable names get rid of final slash that produces // double slashes run only chunk 13 with more detail
jmikedupont2
force-pushed
the
feature/perf
branch
from
e51d171
to
66c3db3
Compare
45930
reviewed
Oct 22, 2024
| @@ -13,3 +13,58 @@ src/config.mlh | |||
| .direnv | |||
| .rustup | |||
| result | |||
| isolate*-v8.log | |||
There was a problem hiding this comment.
Can you move these to your dev environment's global gitignore, rather than the project's?
| branches: | ||
| - main | ||
| workflow_dispatch: | ||
| # push: |
There was a problem hiding this comment.
Are these going to be uncommented back out?
.github/workflows/build-action.yml
Outdated
| @@ -125,7 +138,8 @@ jobs: | |||
| - name: Setup Node | |||
| uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: '18' | |||
| # FIXME change to use matrix | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of perf test and squashing of commits