-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General-purpose token contract #1384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but not yet the new implementation
4 tasks
Trivo25
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! but we should also queue up changes to https://docs.minaprotocol.com/zkapps/o1js/custom-tokens
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports a
TokenContract
which can be extended and contains the blueprint for all token contracts.TokenContract
provides the hard parts of the proposed token standard MIP - namely, theApprovable
andTransferable
APIs.UnfinishedForest
, which is used to record a zkApp's child forest as it gets built up, and that can be "finalized" at the end to get anAccountUpdateForest
.AccountUpdate.children
AccountUpdate.children
in a follow-up PR, and make everything based onUnfinishedForest
.Token contract API
The core method that approves other account updates, called
approveBase()
, is left abstract, i.e. has to be implemented by base classes. It has the following type signature:TokenContract
contains methods that make it very easy to approve and iterate through the forest of child account updates.The canonical implementation is as simple as:
If you want to do something custom for every child account update, this is also pretty easy, using the
forEachUpdate()
helper:This is, of course, built with the
TokenAccountUpdateIterator
from #1398We also provide easier-to-use wrappers for
approveBase()
, so that developers of token zkapps don't have to deal with creating theAccountUpdateForest
correctly. These will be the main API entry-points when using token contracts: