Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for more branches #315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for more branches #315

wants to merge 2 commits into from

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Nov 23, 2024

adds support for more branches (branch ^= methods)

@Trivo25 Trivo25 mentioned this pull request Nov 23, 2024
Open
querolita
querolita approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@querolita querolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but isn't there a way to allow any amount? Without requiring us to manually increase the Nx used for lists.

@hattyhattington17
Copy link

I was wondering about these hardcoded modules too - it sounds like we had a discussion around how we could make them dynamic but the associated issue was closed o1-labs/o1js#934. @Trivo25, did we determine that it was not feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hattyhattington17 hattyhattington17 hattyhattington17 approved these changes

@querolita querolita querolita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trivo25 @hattyhattington17 @querolita