Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: password-protected unpacking #398

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix: password-protected unpacking #398

merged 1 commit into from
Sep 25, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Sep 24, 2024

Description

#397

  • fixed behavior when nzbget didn't use the password found in the nzb file name or in the nzb file itself if the nzb file was added to the queue via command line

Testing

  • Windows 11
    • unrar 7
  • Linux Debian 12
    • unrar 6
    • unrar 7
  • macOS Ventura
    • unrar 7

luckedea
luckedea approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@luckedea luckedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dnzbk dnzbk merged commit 76e2f8a into develop Sep 25, 2024
7 checks passed
@dnzbk dnzbk deleted the fix/unpack-with-password branch September 25, 2024 09:07
@antdude
Copy link

antdude commented Sep 25, 2024

Just tested it since this was my bug! Perfect and thanks. Note: I reused my my old nzbget.conf file since I was lazy to reconfigure from scratch. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckedea luckedea luckedea approved these changes

@phnzb phnzb Awaiting requested review from phnzb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnzbk @antdude @luckedea