MJD/JDE UTC fix + to_time_scale now available in Python
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er have to change it again
src/epoch/mod.rs
Outdated
There was a problem hiding this comment.
Most of the changes here are for the initializers that were moved to initializers.rs.
|
|
||
| #[must_use] | ||
| pub fn from_mjd_utc(days: f64) -> Self { | ||
| Self::from_mjd_in_time_scale(days, TimeScale::UTC) |
There was a problem hiding this comment.
This function previously called from_mjd_tai and then manually applied the leap seconds. Now it calls the from_mjd_in_time_scale function which correctly sets the time scale without changing the duration.
|
|
||
| #[must_use] | ||
| pub fn from_jde_utc(days: f64) -> Self { | ||
| Self::from_jde_in_time_scale(days, TimeScale::UTC) |
There was a problem hiding this comment.
The from_jde_utc function has the same bug as in #302 , so I've done the same fix.
| @@ -2069,11 +2069,17 @@ fn regression_test_gh_282() { | |||
| fn regression_test_gh_288() { | |||
| use core::str::FromStr; | |||
| let epoch = Epoch::from_str("2021-03-06 11:14:40.9960 GPST").unwrap(); | |||
| let epoch_from_gpst = | |||
There was a problem hiding this comment.
Additional test for #257 .
| @@ -2137,3 +2143,32 @@ fn regression_test_gh_317() { | |||
| nanos | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn regression_test_gh_302() { | |||
There was a problem hiding this comment.
New regression test for #302 .
| @@ -25,6 +25,9 @@ def test_strtime(): | |||
| print(f"caught {e}") | |||
| else: | |||
| raise AssertionError("failed to catch parsing error") | |||
|
|
|||
| epoch_tdb = epoch.to_time_scale(TimeScale.TDB) | |||
There was a problem hiding this comment.
Add a Python test for #331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331
Closes #257
Closes #302
This also makes #229 much easier to get started on. My only hesitation with that ticket is that in Python, we use
init_from_unix_secondsa lot and we're launching in a few weeks so I'm hesitant to change my habits this close to launch.