Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trello management class #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cindyke124
Copy link

No description provided.

@AM-git-hub
Copy link

1. Change Granularity
Observation: Changes look like they are well-segmented into appropriately sized commits.
2. Code Functionality
Does the Code Meet Requirements?: Overall, the code seems to meet the task requirements. However, there is no user input being taken and the user has to hardcode the board name and id into the code, making it less intuitive. (Maybe consider using Slack for bot communication?)
Logic Flow: Overall, the Trello connection logic is consistent and flows well, might need to take in user input into consideration.
3. Readability & Structure
Naming Conventions: Variable and function names are intuitive and descriptive
Modularity: The functions in "TrelloManager.py" are well-encapsulated, with single responsibilities.
4. Standards Compatibility
Linting: Code passes linting checks.
API Exposure: The API is only exposed to the classes that use the API.
5. Testing
Coverage: We could not find any unit tests corresponding to the TrelloManager class. The dummy test looks good.
Readability: The dummy test functions are clear and directly validate functionality, although there is no test function for the Trello connection/operations.

Reviewed by:

  1. Adittya Mittal - am14079
  2. Siddharth Singh - sms10221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants