feat: Submission-1 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I tentatively grade this at 95% :) |
|
i left some comments, but more generally, this is "too much" for HW1. also a few follow-ups:
right now, tentatively this is at about 80/100 for me. |
kyotov
reviewed
Oct 30, 2024
AbdullahSuri
force-pushed
the
main
branch
2 times, most recently
from
60369b1 to
e935376
Compare
|
We have reset the main branch to its initial commit and moved Trello and SlackChatbot enhancements to separate branches. We're working on incorporating the feedback, including adding mypy and ruff checks, updating to Python 3.13, and maintaining a minimal repository setup. Further updates will follow in dedicated PRs. |
kyotov
reviewed
Nov 7, 2024
Add TrelloManager feat: Implement OAuth and enhance message handling for Slack bot fix: hw1 feedback fix - Upgrade python from 3.11 to 3.12 - Use uv to transform the project from app to a library, exposing api only via modules (modules named with "_" to discourage direct use and import) - Add mypy for static type checking - Add pytest-cov for test coverage and reporting - Add circleCI tests and coverage report - Untracked artifact files - The project is capable of being built with build-tools (maigic uses hatchling) and probably being published to PyPi
- Upgrade python from 3.11 to 3.12 - Use uv to transform the project from app to a library, exposing api only via modules (modules named with "_" to discourage direct use and import) - Add mypy for static type checking - Add pytest-cov for test coverage and reporting - Add circleCI tests and coverage report - Untracked artifact files - The project is capable of being built with build-tools (maigic uses hatchling) and probably being published to PyPi
HW1 fixedThe project is now updated according to the latest feedback. CircleCI tests show up in the tests tab. Samples in case of success and failure are attached.CircleCI all tests passed:
CircleCI all tests failed:
CircleCI all tests failed test coverage report:
Use this link to check exact diff. There are major changes in the file names and structure, so the diff would be less intuitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the re-submission of submission-1 for the mAIgic team 1.
Team Members:
Satyam Chatrola: [email protected]
Abdullah Suri: [email protected]
Eli Edme: [email protected]
Frank Zhao: [email protected]
Mihir Lovekar: [email protected]
Sidhved Warik: [email protected]
Yaxin Ke: [email protected]