Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: javascript file import bug #14

Merged
merged 1 commit into from
May 12, 2024
Merged

fix: javascript file import bug #14

merged 1 commit into from
May 12, 2024

Conversation

zwinniez
Copy link
Collaborator

@zwinniez zwinniez commented May 12, 2024

Pull Request Template

Description

Fixed the project directory structure to adhere to Flask standards

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • ran pdm run python init.py
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Note:

Include the information the reviewers need to know.

Copy link
Collaborator

@Yanglin-Tao Yanglin-Tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The script import issue should resolve now.

@Yanglin-Tao Yanglin-Tao merged commit b6da798 into main May 12, 2024
1 check passed
@@ -62,6 +62,6 @@ <h2>Starred</h2>
</div>
</div>

<script src="../javascripts/script.js" defer></script>
<script src="../static/javascripts/script.js" defer></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls make sure it works

@zwinniez zwinniez mentioned this pull request May 12, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants