Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "beta" flag and moving to cloud.build.io #54

Merged
merged 13 commits into from
May 30, 2019
Merged

Conversation

jprobinson
Copy link
Contributor

Also bumping up to newer versions of Go and dropping the vendor dir.

🤞 this works

@jprobinson jprobinson requested a review from tonglil May 30, 2019 19:16
.drone.yml Outdated Show resolved Hide resolved
@@ -1,20 +0,0 @@
language: go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.drone.yml Outdated Show resolved Hide resolved
@tonglil
Copy link
Member

tonglil commented May 30, 2019

For some reason it's running test step last. Might due to syntax change.

image

@jprobinson
Copy link
Contributor Author

oof you're right? WTF? 'test' is the first step in the pipeline.

Any suggestions?

@oliver-nyt
Copy link
Contributor

oliver-nyt commented May 30, 2019

Oh, maybe that's cause test is the only step you run that's not using the funky & to reference the config.

@jprobinson
Copy link
Contributor Author

the yaml variables seemed to have messed up the ordering. all fixed now and 🤞 the secrets play nice on merge. If not, brace for another PR 😓

@jprobinson jprobinson merged commit 829c42c into master May 30, 2019
@jprobinson jprobinson deleted the beta-and-drone branch May 30, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants