Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245 feature and optimized #246

Merged
merged 15 commits into from
Nov 24, 2023
Merged

245 feature and optimized #246

merged 15 commits into from
Nov 24, 2023

Conversation

nyomansunima
Copy link
Owner

@nyomansunima nyomansunima commented Nov 24, 2023

What type of PR is this? (check all applicable)

  • ๐ŸšœRefactor
  • โœ… Feature
  • ๐Ÿ› Bug Fix
  • ๐Ÿš€ Optimization
  • ๐Ÿ“ Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #
  • Fixed #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Chechlist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Added/updated tests?

  • ๐Ÿ‘ Yes
  • ๐Ÿ™…โ€โ™€๏ธ No, and this is why: please replace this line with details on why tests
    have not been included
  • โ˜๏ธ I need help with writing tests

Documentation Update Needs ?

  • ๐Ÿ“ Readme
  • ๐Ÿš€ Changelog
  • ๐Ÿฅฐ Contributing
  • ๐Ÿ™…โ€โ™€๏ธ No, Docs Already Update

Are there any post deployment tasks we need to perform?

Copy link
Owner Author

@nyomansunima nyomansunima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everthing cool

@nyomansunima nyomansunima self-assigned this Nov 24, 2023
@nyomansunima nyomansunima merged commit 83dba6e into main Nov 24, 2023
2 checks passed
@nyomansunima nyomansunima deleted the 245-feature-and-optimized branch November 24, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant