Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: nym-credential-proxy webhook request is the correct shape #5077

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Bug fix: nym-credential-proxy webhook request is the correct shape #5077

merged 1 commit into from
Nov 1, 2024

Conversation

mmsinclair
Copy link
Contributor

@mmsinclair mmsinclair commented Nov 1, 2024 •
edited
Loading

  • webhook requests are sent in the correct shape for the webhook to process
  • added reporting of errors via the webhook (relies on the webhook URL being configured correctly and being available to receive the errors)

This change is Reviewable

@octol octol merged commit 80b590d into release/2024.13-magura Nov 1, 2024
10 of 13 checks passed
@octol octol deleted the bugfix/credential-proxy-webhook branch November 1, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol approved these changes

@jstuczyn jstuczyn Awaiting requested review from jstuczyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsinclair @octol