[Product Data] Second step in gateway usage data collection #4964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
approved these changes
Oct 12, 2024
simonwicky
force-pushed
the
simon/gateway_stats_collector
branch
from
3fef9b9
to
1d2d8e0
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@octol |
simonwicky
added a commit
that referenced
this pull request
Oct 15, 2024
* add stats model * add stats collection * add stats route * propagate stuff and run stuff * cargo stuff * sqlx unused what? * add sessions started stat * session durations in miliseconds * apply Jon's comments * [Product Data] Second step in gateway usage data collection (#4964) * turn stats collection into event based * move events into a common crate for future use elsewhere * apply Jon's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is the second step towards collecting data on gateway usage.
It builds on top of #4963
What it does
Turn the data collection into an event-based one, which allows more accurate results and more flexibility for future data collection.
This change is