Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde from workspace #4833

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Use serde from workspace #4833

merged 2 commits into from
Sep 16, 2024

Conversation

octol
Copy link
Contributor

@octol octol commented Sep 2, 2024

  • cargo autoinherit for serde
  • cargo autoinherit for bs58 and vergen in cosmwasm-smart-contracts

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:53am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:53am

@octol octol marked this pull request as ready for review September 2, 2024 13:28
@octol octol requested a review from jstuczyn as a code owner September 2, 2024 13:29
Base automatically changed from jon/remove-serde_crate-import to develop September 2, 2024 13:51
@octol octol force-pushed the jon/cargo-autoinherit-serde branch from 57fc4c6 to 385532b Compare September 2, 2024 13:52
Copy link
Contributor

@dynco-nym dynco-nym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks good and compiles

@octol octol added this to the Aero milestone Sep 16, 2024
@octol octol merged commit 086611c into develop Sep 16, 2024
21 of 22 checks passed
@octol octol deleted the jon/cargo-autoinherit-serde branch September 16, 2024 09:16
@octol
Copy link
Contributor Author

octol commented Sep 16, 2024

For QA: this regression testing on the contracts next time we release a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants