Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch double-opening bug #90

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

ashlyn
Copy link
Contributor

@ashlyn ashlyn commented Apr 5, 2022

Patching a small defect that was fixed locally but inadvertently not pushed up along with the changes for 0.7.1. Using just one of either the onClick handler with the openBrowserWindow function or the href attribute for external links should fix a bug where clicking the external links on Pocket items will open two tabs with the same link. Testing steps were the same as #89.

ashlyn and others added 2 commits April 5, 2022 11:49
only need to specify latest version of `obsidian-pocket` per version compatible of Obsidian
Copy link
Owner

@nybbles nybbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix and sorry for the wait to get this merged.

@nybbles nybbles merged commit a95bdd9 into nybbles:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants