Update Roxygen comments (examples) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
force-pushed
the
update-roxygen-comments
branch
from
3c6fde7 to
a4a3fb7
Compare
eitsupi
commented
Jan 25, 2023
|
Looks excellent, thank you! |
nx10
reviewed
Jan 25, 2023
|
Also: Add yourself to the list of contributors inside the DESCRIPTION (if you want to) 🚀 |
kar9222
pushed a commit
to kar9222/httpgd
that referenced
this pull request
Apr 22, 2023
* update examples not to use `dontrun` in Rd files * update hgd_id usage * add missing @return comment * remove unnecessary hgd() and dev.off() * add a new contributor * remove tmpfiles on exit
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #128
Most of the examples looked fine to me to run.
I've wrapped only the ones that are meaningless unless they are executed interactively with
if (interactive()).(This is a way used by shinyWidgets, for example. https://github.com/dreamRs/shinyWidgets/blob/f37e59a33630efc358e9b317207643c99f67d4df/R/input-autonumeric.R#L53-L89)
Feel free to edit this branch if you find anything inappropriate.