Skip to content

Commit

Permalink
chore(deps): upgrade nw
Browse files Browse the repository at this point in the history
  • Loading branch information
ayushmanchhabra committed Apr 14, 2024
1 parent 244857a commit e9f888d
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ jobs:
- name: Install Pip dependencies
run: python3 -m pipenv install
- name: Run Python tests
run: python3 -m pipenv run pytest ./py/selenium/builder/*.py
run: python3 -m pipenv run pytest ./py/selenium/servie_builder/*.py
3 changes: 2 additions & 1 deletion js/selenium/service_builder/service_builder.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ describe('NW.js Selenium ServiceBuilder test suite', async () => {

options.addArguments(seleniumArguments);

const chromeDriverPath = await findpath('chromedriver', { flavor: 'sdk' });
/* Pass file path of NW.js ChromeDriver to ServiceBuilder */
const service = new chrome.ServiceBuilder(findpath('chromedriver')).build();
const service = new chrome.ServiceBuilder(chromeDriverPath).build();

/* Create a new session using the Chromium options and DriverService defined above. */
driver = chrome.Driver.createSession(options, service);
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"devDependencies": {
"base-volta-off-of-nwjs": "^1.0.5",
"nw": "^0.86.0-2",
"nw": "^0.86.0-3",
"puppeteer": "^22.6.4",
"selenium-webdriver": "^4.19.0",
"vitest": "^1.5.0"
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ class TestWindow(TestCase):
Setup Selenium driver.
'''
def setUp(self):

# Set NW.js project root to present working directory
# NW.js project requires an index.html and package.json
pwd = os.path.dirname(os.path.abspath(__file__))
sys.path.append(pwd)

# We are using the nw node module to download NW.js
# Change the path as necessary
chromedriver_path = "./node_modules/nw/nwjs/chromedriver"
Expand All @@ -28,7 +22,7 @@ def setUp(self):

options = webdriver.ChromeOptions()
# File path to NW.js project
options.add_argument("nwapp=" + "./py/selenium/builder")
options.add_argument("nwapp=" + "py/selenium/builder")
# Useful if running in CI
options.add_argument("headless=new")

Expand Down

0 comments on commit e9f888d

Please sign in to comment.