fix(py): correct chromedriver path

nwutils · Apr 14, 2024 · 9948d52 · 9948d52
1 parent a97ee0b
commit 9948d52
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,10 @@ jobs:
   test:
     strategy:
       matrix:
-        os: [macos-12, ubuntu-22.04, windows-2022]
+        os:
+        - macos-12
+        - ubuntu-22.04
+        - windows-2022
       fail-fast: false
     runs-on: ${{ matrix.os }}
     steps:
@@ -38,7 +41,7 @@ jobs:
       - name: Run Node tests
         run: npm t
       - name: Install pipenv
-        run: pip install pipenv
+        run: python3 -m pip install pipenv
       - name: Install Pip dependencies
         run: python3 -m pipenv install
       - name: Run Python tests

diff --git a/py/selenium/builder/test.py b/py/selenium/builder/test.py
@@ -21,14 +21,14 @@ def setUp(self):
 
         # We are using the nw node module to download NW.js
         # Change the path as necessary
-        chromedriver_path = "./node_modules/nw/nwjs/chromedriver"
+        chromedriver_path = "./node_modules/nw/nwjs/nw/chromedriver" + (".exe" if sys.platform == "win" else "")
 
         if sys.platform == "win":
             chromedriver_path += ".exe"
 
         options = webdriver.ChromeOptions()
         # File path to NW.js project
-        options.add_argument("nwapp=" + pwd)
+        options.add_argument("nwapp=" + "./py/selenium/builder")
         # Useful if running in CI
         options.add_argument("headless=new")