fix: move ffmpeg to correct folder after extract

[zkrige]

Fixes: #916

Description

reinstate the replaceFfmpeg code that was removed during cleanup

[ayushmanchhabra]

Thanks for this! One case where this fails is when initially ffmpeg is false and a binary is already cached. But enabling ffmpeg does not download it since it thinks its already "cached".

Maybe we can add this here:

- if (nwCached === false) {
+if (nwCached === false || ffmpeg === true) { 

[zkrige]

It needs to be a little bit smarter otherwise it will download ffmpeg every time. we only want to download ffmpeg if it hasn't been downloaded.

your solution will for for now, but ideally it should check if ffmpeg must be downloaded

[ayushmanchhabra]

It needs to be a little bit smarter otherwise it will download ffmpeg every time. we only want to download ffmpeg if it hasn't been downloaded.

Exactly what I was thinking.

your solution will for for now, but ideally it should check if ffmpeg must be downloaded

I'll look into how to make this happen.

[zkrige]

@ayushmanchhabra hmmm this is still broken

await replaceFfmpeg(platform, nwDir, out);

just ends up copying the zip file over itself. We need some way to get the extracted filename